Fix aggte failure after pickle reload due to non-numeric column (Issue #71)#73
Merged
alexanderquispe merged 1 commit intod2cml-ai:mainfrom Jan 13, 2026
Merged
Fix aggte failure after pickle reload due to non-numeric column (Issue #71)#73alexanderquispe merged 1 commit intod2cml-ai:mainfrom
alexanderquispe merged 1 commit intod2cml-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolution of Issue #71
This pull request fixes Issue #71, where aggte() fails after reloading a csdid result from a pickle file. The attached notebook provides a minimal replication of the failure and demonstrates the corrected behavior.
aggte_rowid_jupytext.ipynb
Root cause:
After reloading a saved csdid object, the internal data frame used in aggte_fnc/compute_aggte.py may contain a non-numeric column named rowid. During aggregation, the code groups the data and applies mean() across remaining columns, causing pandas to raise:
TypeError: agg function failed [how->mean, dtype->object]
Fix:
Before the aggregation step, the fix removes the rowid column if present:
if 'rowid' in data.columns:
data = data.drop(columns=['rowid'])
This restores correct execution of aggte() for both freshly computed and reloaded csdid objects, without affecting existing results.